Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 1436 load api defintion from url #3059

Merged
merged 3 commits into from
May 27, 2024
Merged

Feature 1436 load api defintion from url #3059

merged 3 commits into from
May 27, 2024

Conversation

winzj
Copy link
Member

@winzj winzj commented Apr 4, 2024

@winzj winzj self-assigned this Apr 16, 2024
@winzj winzj requested a review from de-jcup April 16, 2024 08:02
de-jcup
de-jcup approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

I have some thoughts and found some minor parts but I think it is good enough to merge directly. But please read my comments and decide if there are small changes necessary or not.

...wasp-zap/src/main/java/com/mercedesbenz/sechub/zapwrapper/internal/scan/ClientApiFacade.java Show resolved Hide resolved
...l/src/test/java/com/mercedesbenz/sechub/commons/model/SecHubWebScanApiConfigurationTest.java Show resolved Hide resolved
...l/src/test/java/com/mercedesbenz/sechub/commons/model/SecHubWebScanApiConfigurationTest.java Outdated Show resolved Hide resolved
...uments/shared/configuration/sechub_config_example8_web_scan_openapi_with_data_reference.json Show resolved Hide resolved
...sp-zap/src/test/resources/sechub-config-examples/no-auth-with-openapi-from-file-and-url.json Show resolved Hide resolved
@winzj winzj merged commit 839cab9 into develop May 27, 2024
2 checks passed
@winzj winzj deleted the feature-1436-load-api-defintion-from-url branch May 27, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-jcup de-jcup de-jcup approved these changes

Assignees

@de-jcup de-jcup

@winzj winzj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webscan config support loading api definitions from URL
2 participants
@winzj @de-jcup